Skip to content

test: await ky post and add delete route test#114

Open
saitejabandaru-in wants to merge 4 commits into
tscircuit:mainfrom
saitejabandaru-in:fix/switch-to-ky-tests
Open

test: await ky post and add delete route test#114
saitejabandaru-in wants to merge 4 commits into
tscircuit:mainfrom
saitejabandaru-in:fix/switch-to-ky-tests

Conversation

@saitejabandaru-in

Copy link
Copy Markdown

Summary

  • Awaits the ky.post creation request in create.test.ts to prevent race conditions and asserts { ok: true }.
  • Adds tests/routes/things/delete.test.ts to cover the delete route with URL-encoded form data and verify deletion using ky.

/claim #2

@saitejabandaru-in

Copy link
Copy Markdown
Author

I have added the missing regression tests for request body handling and persisted responses to tighten the ky migration coverage, as pointed out in the recent issue comments. The test suite passes locally with bun test. Let me know if there is anything else needed!

@saitejabandaru-in

Copy link
Copy Markdown
Author

Hi @tscircuit maintainers! Friendly nudge on this PR. It is mergeable, all tests pass, and it covers the request body handling/persisted responses for the ky migration as requested in issue #2. Let me know if any changes are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant