Fixes #30 /claim #30 - #164
Open
theherrovn-sys wants to merge 1 commit into
Open
Conversation
theherrovn-sys
requested review from
ShiboSoftwareDev and
seveibar
as code owners
May 31, 2026 10:07
MikeGarciaAGM
approved these changes
Jun 9, 2026
MikeGarciaAGM
left a comment
There was a problem hiding this comment.
Looks good. The response-object check and exception handling changes are tightly scoped, and the new coverage matches the intended contract cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30 /claim #30
withResponseObjectCheckmiddleware to throwRawJsonResponseError(extendsBadRequestError, anHttpException) instead of plainErrorwithUnhandledExceptionHandlingto return proper JSON error responses forHttpExceptioninstances instead of blank 500 responsesdo-not-allow-raw-jsonandinvalid-response-errortests