Enable Sourcemap Output - #39
Merged
Merged
Conversation
abimaelmartell
force-pushed
the
enable-source-maps
branch
from
August 11, 2025 22:07
92bf676 to
667752a
Compare
abimaelmartell
marked this pull request as ready for review
August 11, 2025 23:21
abimaelmartell
requested review from
ShiboSoftwareDev and
seveibar
as code owners
August 11, 2025 23:21
seveibar
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds robust support for source map generation in the bundling process, allowing users to choose between inline, external, or no source maps. It updates the CLI and internal APIs to handle these options, ensures correct file outputs, and introduces comprehensive tests to verify the new functionality.
Source map support in bundling:
bundlefunction to accept asourcemapoption (inline,external, ornone) and return both the bundled code and, if applicable, the source map. The implementation writes external source maps to a temporary file due to esbuild limitations. [1] [2]bundlefunction across the codebase to handle the new return type and options, including CLI commands and tests. [1] [2] [3] [4] [5]CLI improvements:
bundleCLI command to accept a--sourcemapoption, validated its value, and handled writing external source map files alongside the bundle output. Updated help and examples accordingly.Testing:
tests/bundle/sourcemap.test.ts) with thorough coverage for all source map options, including validation of inline/external maps, bundle size comparisons, and platform compatibility.Other updates: