Added support for c++ #59
Open
+42
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dminnimda
reviewed
Apr 28, 2025
Comment on lines
+1587
to
+1592
| size_t new_count; | ||
| #ifndef _WIN32 | ||
| long m; | ||
| #else | ||
| long long m; | ||
| #endif |
There was a problem hiding this comment.
Why did you separate declaration and initialization? does c++ not work without it?
Comment on lines
+12
to
+15
| const char *message; | ||
| const char *message_file_path; | ||
| Proc p; | ||
| String_View actual_message; |
There was a problem hiding this comment.
Because the preprocessor (and goto) rules in C++ are strictier than the C. The usage of "return_defer" macro must be after all declaration. So you cannot jump with goto after a declaration+initialization of a variable. So i simply separated them and all works as expected
gkgoat1
reviewed
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi tsoding, i love this project and i would love to use it with c++. I have modified nob.h (and a test) to compile with g++ and clang++. I have run the nob with c and c++ with my modified version and both works! The only "meh", is that with c++ you have a lot of warnings in the tests (because of some differences between c and c++) but all works as expected i think