Add check for __clang__
in lone _MSC_VER
checks
#66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nob_cc_flags
andnob_cc_output
macros check for_MSC_VER
to provide MSVC-specific argument syntax. When using Clang on Windows it provides many of the same flags as MSVC, presumably for Windows compat, so Nob was generating MSVC flags for a Clang compiler call.This is not an issue in other locations as
__clang__
is checked for explicitly and before_MSC_VER
, such as in the relatednob_cc
macro for selecting the appropriate compiler program name.