mouse-click support in core_basic_screen_manager #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core_basic_screen_manager, as well as disabling right-click context menu in the game canvas
AntonPieper
reviewed
Feb 13, 2024
rexim
reviewed
Feb 17, 2024
RobLoach
reviewed
Feb 27, 2024
| this.currentMousePosition = {x: e.clientX, y: e.clientY}; | ||
| }; | ||
| const gestureTap = (e) => { | ||
| this.currentGestureState = gestureMapping.GESTURE_TAP; |
There was a problem hiding this comment.
This will register a GESTURE_TAP if the middle-mouse button is pressed, and never actually release it. I'm not sure this is the intended behavior.
|
I'd recommend using the mouse events for the actual mouse via #41 , and saving gestures for the WebAPI touch events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added initial support for gestures, namely GESTURE_TAP which is used in core_basic_screen_manager, as well as disabling right-click context menu in the game canvas