Feature: docker buildの開発者体験をいい感じにする #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #6
WHY
現在のDockerfileにはいくつかの問題があった．
git clone ...で持ってきていたこれらの問題に対処し，同時にdocker buildの実行時間を早くしたい（ついでにイメージの縮小化もできると...嬉しい!!）
WHAT
COPY . /ns3-gymによるコピーに変更する（ [WIP] ChatGPTによるアルゴリズムの自動生成の検証 #5 ではすでに入っている）.dockerignoreを追加し，不要なファイルをコンテナに載せないようにするapt-get cleanを追加し，イメージの縮小かOther
/scratch/rl-tcp/*.pyをdocker run時にマウントしてもうまく動くならそう変更したい（COPYの対象から外すことができ，docker build時にcacheが効きやすくなるので）