Fixed Enter key behavior and added toggles#95
Open
Lyqed wants to merge 3 commits intotth05:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Enter key behavior and added toggles. Previously, Enter would only bypass to create a new line when popup wasn't focused, which was unintuitive since the first suggestion is just the current word. Now Enter properly creates a new line when no real suggestion is selected (ignoring the first one which is just the current word). Added settings to control both behaviors: "Hide current word suggestion" toggle to remove the redundant first suggestion entirely, and "Enter creates new line" toggle to control whether Enter should create a new line when no suggestion is selected. Both enabled by default for a cleaner UX.