feat: compose Q10 map content from grouped traits - #3
Closed
tubededentifrice wants to merge 8 commits into
Closed
Conversation
tubededentifrice
force-pushed
the
agent/q10-map-traits
branch
from
July 19, 2026 15:45
05a0479 to
8829cb1
Compare
tubededentifrice
force-pushed
the
agent/q10-map-renderer
branch
2 times, most recently
from
July 19, 2026 16:24
a924f7a to
50d92a9
Compare
tubededentifrice
force-pushed
the
agent/q10-map-traits
branch
from
July 19, 2026 16:26
8829cb1 to
6e9d62e
Compare
tubededentifrice
force-pushed
the
agent/q10-map-renderer
branch
from
July 19, 2026 16:45
50d92a9 to
303fe71
Compare
tubededentifrice
force-pushed
the
agent/q10-map-traits
branch
from
July 19, 2026 16:46
6e9d62e to
69e1347
Compare
tubededentifrice
force-pushed
the
agent/q10-map-renderer
branch
from
July 19, 2026 17:13
303fe71 to
4da996c
Compare
tubededentifrice
force-pushed
the
agent/q10-map-traits
branch
from
July 19, 2026 17:17
69e1347 to
2db38da
Compare
* feat: compose Q10 maps in a pure renderer * refactor: keep Q10 render intermediates internal * refactor: render Q10 maps through one image path
Owner
Author
|
Superseded by upstream PR Python-roborock#886 after Python-roborock#885 merged. The branch was updated incrementally and its history was not rewritten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final PR in the Python-roborock#848 split: integrates the pure renderer through a low-level/high-level trait boundary based on maintainer feedback about mutable state and mixed update sources.
This fork-local draft is stacked on Python-roborock#885, so its incremental diff contains only trait/API/CLI integration. It can be promoted upstream once Python-roborock#885 lands.
State ownership
MapDpsTraitowns restricted-zone and virtual-wall DPS values.MapContentTraitgroups the latest map and trace protocol packets in one immutableQ10MapSource.MapData, and rendering intermediates are not exposed.The stale layer-export CLI was removed. The path-specific CLI only waits for a live trace and saves the trait's normal
image_content; it does not invoke an alternate renderer.Validation
pytest -q— 797 passed, 86 snapshots passedpre-commit run --show-diff-on-failure --color=always --all-files— all hooks passed, including ruff and mypyStack