Add the East Pacific tropical outlook map - #37
Merged
Conversation
The NHC publishes its two-day tropical weather outlook as one graphic per basin, so the single Atlantic image showed nothing at all for a storm off Baja California. Add image.noaa_hurricane_pacific_outlook_image alongside it on the existing NOAA Hurricane device, and move the Atlantic image to NHC's larger xgtwo_atl_2d0.png rendering. The Atlantic entity keeps its ID and its basin-neutral name so existing dashboards and automations keep working. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BArYuFJgY4WSgps3pHL2SU
Move the Pacific outlook entries into their own changelog section; they were filed under 0.7.0, which is already out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BArYuFJgY4WSgps3pHL2SU
turbo5000c
marked this pull request as ready for review
September 7, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The hurricane outlook tile only ever showed the Atlantic, because the NHC publishes its two-day tropical weather outlook as one graphic per basin — a storm off Baja California never appeared on it.
image.noaa_hurricane_pacific_outlook_image("Pacific Outlook Image") on the existing shared NOAA Hurricane device, fed byhttps://www.nhc.noaa.gov/xgtwo/xgtwo_pac_2d0.png.xgtwo_atl_2d0.pngrendering instead oftwo_atl_2d0.png. Same map, more readable on a dashboard.The Atlantic entity keeps its unique ID (
noaa_hurricane_outlook_image) and its basin-neutral name, so existing dashboard cards and automations keep working. Only the upstream URL changed there.Both URLs came from the request; they could not be fetched from the build sandbox (the egress proxy denies
www.nhc.noaa.gov), so they are used verbatim and are worth an eyeball on a live install.Files changed
custom_components/noaa_it_all/image.py—HURRICANE_PACIFIC_OUTLOOK_URL,HurricanePacificOutlookImageEntity, registered next to the other global hurricane images;HURRICANE_OUTLOOK_URLswapped to the larger Atlantic graphic.custom_components/noaa_it_all/manifest.json— version0.7.0→0.7.1.tests/test_image.py— new property tests, a basin-URL regression test, and the new entity added to the existing global-hurricane / content-type / log-label / no-state-write sweeps.README.md,CONFIGURATION.md,CHANGELOG.md— entity lists, the "no office code" exception tables, and a new[0.7.1]changelog section.Type
Checklist
Testing
Run locally, both as CI runs them:
python -m pytest tests/— 1083 passed, 42 subtests passedflake8 custom_components/noaa_it_all/ --max-line-length=120andflake8 tests/ --max-line-length=120— cleanNew coverage:
TestHurricanePacificOutlookImageEntity(name, unique_id,has_entity_name, hurricane device) andTestHurricaneOutlookSources, which pins each basin to its own graphic — a copy-paste slip leaving both entities on the Atlantic URL would otherwise pass the whole suite.Risks / follow-ups
CONFIGURATION.mdsection 2 ("NOAA Weather") still listsimage.noaa_hurricane_outlook_imageandimage.noaa_hurricane_goes_geocolor, which live on the NOAA Hurricane device in section 4. Pre-existing, left alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01BArYuFJgY4WSgps3pHL2SU