Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreate activities on screenLayout change #4689

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Recreate activities on screenLayout change #4689

wants to merge 1 commit into from

Conversation

JimmyJichi
Copy link

Fixes #4255

Tested on Pixel 9 Pro Fold.

Before

screen-20240918-003325.mp4

After

screen-20240918-005909.mp4

@connyduck
Copy link
Collaborator

If it only was that easy 🥺
This should only be done once MainActivity has a ViewModel, otherwise it will reload on every layout change. But this is my top priority, I'll add that soon and then merge this PR.

@JimmyJichi
Copy link
Author

This should only be done once MainActivity has a ViewModel, otherwise it will reload on every layout change.

I can see a brief reload animation, but the timeline stays where it was. I'd argue that's acceptable. Definitely better than having a broken layout.

output.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folding Phone Messes With Layout
2 participants
@JimmyJichi @connyduck