Improve EML export: Handle plain text and HTML bodies correctly #8833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for the fix, but I think tests need some fixing |
firefly-cpp
force-pushed
the
eml-export-plain-vs-html
branch
from
761bc51 to
33fc328
Compare
|
@charlag, please re-run pipeline. Lint issues are still present (for now). |
|
Thank, would be good to add a test for text/html specifically but we can also do it later |
|
Thanks! Yes. Good point! However, we can leave it for now and count on this for further iterations. Please take a look at the linter issue. TS isn’t my primary environment, so fixing these problems can be a bit time-consuming for me. |
|
If you just run |
charlag
force-pushed
the
eml-export-plain-vs-html
branch
from
33fc328 to
5a239da
Compare
|
I formatted it and added a test case, it's good to go for the next release :) |
charlag
approved these changes
Apr 7, 2025
hrb-hub
force-pushed
the
dev-mail
branch
2 times, most recently
from
6b77beb to
5b869d5
Compare
hrb-hub
force-pushed
the
eml-export-plain-vs-html
branch
from
5a239da to
1be9087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor fix ensures the correct Content-Type is set based on the email content. Without it, plain text emails would be incorrectly marked as HTML, which can cause formatting issues or display problems in some email clients.