Fix align SVG icon with text in masthead notice #40897
Open
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SVG icon (arrow right) was not aligned correctly with the masthead notice text when the screen size became smaller than 576px because the class
d-sm-inline-flex
is used, which removes thedisplay: inline-flex;
when the screen size is below 576px. But this needed to be removed because when the masthead notice breaks to a new line, the entire element looks weird. Therefore, I came with a slightly different solution that resolved the issue.Before:
Screen size ≥576px
Screen size <576px
After:
Screen size ≥576px
Screen size <576px
Motivation & Context
align-items-center
andgap-1
classes only worked when thed-sm-inline-flex
class was active. When the screen size is smaller than 576px,d-sm-inline-flex
class is removed, which leaves unused styles in the file and makes it bigger for no reason. The new solution avoids this.Type of changes
Checklist
npm run lint
)Live previews
Related issues