Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken documentation pages in mobile view #8432

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

khuddite
Copy link
Contributor

@khuddite khuddite commented Nov 8, 2024

Fixes: #8396

  1. Summary
    The document content container is missing width and has only padding CSS property, which means the width can overflow its parent based on the content. The code block inside headings was missing fontSize for mobile view, it was set for only desktop views.

  2. Solution
    I set width for document content container and fontSize for code blocks in headings for mobile view.

  3. Screenshots

localhost_3000_developers_local-setup(iPad Mini)
localhost_3000_developers(iPhone 12 Pro)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes mobile view layout issues in the documentation pages by addressing content overflow and code block font sizing problems.

  • Added width: 100% to StyledWrapper in DocsContent.tsx for screens under 450px to prevent content overflow
  • Added font-size: 16px for code blocks within h1-h4 headings in ArticleContent.tsx for screens under 810px
  • Fixed responsive layout in DocsContent.tsx with proper media query breakpoints for different screen sizes
  • Improved mobile readability by adjusting heading font sizes in ArticleContent.tsx for screens under 810px

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FelixMalfait FelixMalfait merged commit ff77f85 into twentyhq:main Nov 11, 2024
16 checks passed
Copy link

Thanks @khuddite for your contribution!
This marks your 4th PR on the repo. You're top 9% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with documentation in mobile view
2 participants