Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some design tweaks to make voice-client-javascript more mobile friendly. #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philnash
Copy link
Contributor

Description

  • Changes layout to flex box
  • Adds a break point to flow vertically on small screens
  • Puts number and call button on far left/top of screen instead of the middle

It now looks like this on desktop:

client-desktop

And this on a thinner device:

client-mobile

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

- Changes layout to flex box
- Adds a break point to flow vertically on small screens
- Puts number and call button on far left/top of screen instead of the middle
@philnash
Copy link
Contributor Author

Hey @craigsdennis, this was your function. What do you think about these changes?

(I can't request a review from you I'm afraid.)

@philnash
Copy link
Contributor Author

On second thoughts, I still don't like this. I'm going to spend a bit of time at some point making this look nicer. I'm no designer, but this is overall too busy and I think I can do a bit better and keep all of the features.

@dkundel
Copy link
Contributor

dkundel commented Apr 2, 2020

Are still going to keep working on this? :) Just checking in whether to merge this or not

@philnash
Copy link
Contributor Author

philnash commented Apr 2, 2020

@dkundel Ah, @craigsdennis told me that the quick start itself was getting a design makeover so was going to wait that out.

@dkundel dkundel added the blocked label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants