finagle-core: Deposit budget once in MethodBuilder #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieBauer
force-pushed
the
methodbuilder-deposits
branch
from
140afff
to
aafb693
Compare
|
@DieBauer - this code isn't compiling, and when i fix it the |
Problem The methodbuilder interface applies the same retrybudget for RetryFilter and RequeueFilter in the same stack. Resulting in double deposit of retrybudget. Solution Re-use the WithdrawOnlyRetryBudget to prevent depositing successes in the RequeueFilter and only deposit in the RetryFilter. Same solution as the `Retries.moduleWithRetryPolicy` takes. Result Retrybudget only gets deposited once for a request.
DieBauer
force-pushed
the
methodbuilder-deposits
branch
from
aafb693
to
a569f1a
Compare
|
I've rebased to develop (SNAPSHOTS were shifted). And an assert was indeed wrong. In the last testcase .retry.disabled, you do not expect any 'retries' stat to be present! Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The methodbuilder interface applies the same retrybudget for RetryFilter and RequeueFilter in the same stack. Resulting in double deposit of retrybudget.
Solution
Re-use the WithdrawOnlyRetryBudget to prevent depositing successes in the RequeueFilter and only deposit in the RetryFilter. Same solution as the
Retries.moduleWithRetryPolicytakes.Result
Retrybudget only gets deposited once for a request.
Closes #956