Skip to content

enhancement/1 json carousel #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

tyler-vs
Copy link
Owner

  • Add instructions for running example locally
  • Update HTML content
  • Update script
  • Update script comments
  • Move carousel initialization to index.html
  • Add jsdocs to methods
  • Return if no value was passed for parameter
  • Update carousel empty element with more data- attributes for features
  • Add auto controls feature check
  • Add renderAutoControls method
  • Remove commented out code
  • Replace renderButtons with renderAutoControls
  • Uncomment fade related code in the JSON slider's constructor
  • Update styles with button and fade support
  • Remove unnecessary code
  • Update placeholder div element with data- attributes
  • Add support for captions
  • Add support for pager
  • Add event listeners for "slide to" buttons
  • Fix left/prev button styles
  • Add inspiration section
  • Move slides variables
  • Add errors.js
  • Include errors.js to example
  • Throw custom error if no selector
  • Replace x with this.slides
  • Remove x variable
  • Change new of showDivs method to showSlide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant