-
Notifications
You must be signed in to change notification settings - Fork 0
enhancement/1 json carousel #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tyler-vs
wants to merge
28
commits into
main
Choose a base branch
from
enhancement/1-json-carousel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tyler-vs
commented
Dec 21, 2021
- Add instructions for running example locally
- Update HTML content
- Update script
- Update script comments
- Move carousel initialization to index.html
- Add jsdocs to methods
- Return if no value was passed for parameter
- Update carousel empty element with more data- attributes for features
- Add auto controls feature check
- Add renderAutoControls method
- Remove commented out code
- Replace renderButtons with renderAutoControls
- Uncomment fade related code in the JSON slider's constructor
- Update styles with button and fade support
- Remove unnecessary code
- Update placeholder div element with data- attributes
- Add support for captions
- Add support for pager
- Add event listeners for "slide to" buttons
- Fix left/prev button styles
- Add inspiration section
- Move slides variables
- Add errors.js
- Include errors.js to example
- Throw custom error if no selector
- Replace x with this.slides
- Remove x variable
- Change new of showDivs method to showSlide
Must come after super.init()
A more meaningful name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.