Skip to content

Improve RolesAuthorizationFilter javadoc #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vjlamp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve RolesAuthorizationFilter javadoc #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de872b2
Javadoc improvements. No functional changes.
vjlamp Feb 23, 2026
8451bfb
Wording improved. Description corrected.
vjlamp Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@


/**
* Filter that allows access if the current user has the roles specified by the mapped value, or denies access
* if the user does not have all of the roles specified.
* Filter that allows access based on all of the roles specified by the mapped value.
* Access is granted if <em>no roles are specified</em> or if the current user has <em>all</em> of the roles.
* Access is denied if the current user does not have all of the roles.
*
* @since 0.4.0
*/
Expand All @@ -40,8 +41,13 @@ public RolesAuthorizationFilter(LoginContextService loginContextService) {
super(loginContextService);
}

//TODO - complete JavaDoc

/**
* {@inheritDoc}
* @param request {@inheritDoc}
* @param response {@inheritDoc}
* @param mappedValue a String array containing the roles all of which the current user must <em>all</em> have to be granted access
* @return {@inheritDoc}
*/
@SuppressWarnings({"unchecked"})
public boolean isAccessAllowed(ServletRequest request, ServletResponse response, Object mappedValue) throws IOException {

Expand Down