refactor: migrate to signals #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheikalthaf
force-pushed
the
signals
branch
2 times, most recently
from
c9f4ed3
to
5151dc5
Compare
|
Hi, I'll review it tomorrow! |
sheikalthaf
changed the title
geromegrignon
requested changes
Jun 10, 2024
| map(results => results.map(this.mapToSearchResult)) | ||
| ); | ||
| search = toSignal(this.searchField.valueChanges.pipe(debounceTime(150))); | ||
| focus = signal(0); |
There was a problem hiding this comment.
I'd prefer to keep the 'INIT' / 'FOCUS' logic as more explicit than using numbers.
There was a problem hiding this comment.
@geromegrignon removed the focus here, without this also search working same as before.
|
@geromegrignon can you review and merge this PR first then we can review the Prettier PR. |
geromegrignon
approved these changes
Aug 19, 2024
|
Reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.