Skip to content

Actually run JVM IOApp tests in CI #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
+6 −3
Merged

Actually run JVM IOApp tests in CI #4518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4418125
Actually run JVM `IOApp` tests in CI
armanbilge Oct 23, 2025
0843dc1
Try to make test more robust
armanbilge Oct 23, 2025
42520b4
Make long literal explicit
armanbilge Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ lazy val rootJVM = project
core.jvm,
testkit.jvm,
tests.jvm,
ioAppTestsJVM,
std.jvm,
example.jvm,
graalVMExample,
Expand Down
8 changes: 5 additions & 3 deletions tests/shared/src/main/scala/catseffect/examples.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,12 @@ package examples {
} catch {
case _: TimeoutException => println("sadness (timeout)")
}
Thread.sleep(500L)
// by now the WSTP (and all its threads) must've been shut down:
if (thread eq null) println("sadness (thread is null)")
else if (thread.isAlive()) println("sadness (thread is alive)")
else {
thread.join(2000L)
// by now the WSTP (and all its threads) must've been shut down:
if (thread.isAlive()) println("sadness (thread is alive)")
}
println("done")
}
}
Expand Down
Loading