Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy unnecessary cast in JS Socket #3352

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Tidy unnecessary cast in JS Socket #3352

merged 1 commit into from
Dec 23, 2023

Conversation

armanbilge
Copy link
Member

This looks like a hold-over from the auto-generated facade days, which was unable to properly encode that the Node.js Socket implements the Writable interface.

@mpilquist mpilquist merged commit 871e16a into main Dec 23, 2023
31 checks passed
@mpilquist mpilquist deleted the topic/no-js-socket-write-cast branch December 23, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @mpilquist