You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+14-1Lines changed: 14 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -43,7 +43,7 @@ Draft PRs won't be reviewed.
43
43
44
44
#### Granular PRs
45
45
46
-
Please keeep pull requests single-purpose: in other words, don't attempt to solve multiple unrelated problems in one pull request.
46
+
Please keep pull requests single-purpose: in other words, don't attempt to solve multiple unrelated problems in one pull request.
47
47
Send one PR per area of concern.
48
48
Multi-purpose pull requests are harder and slower to review, block all changes from being merged until the whole pull request is reviewed, and are difficult to name well with semantic PR titles.
49
49
@@ -55,6 +55,15 @@ A maintainer will look at it when they're next able to.
55
55
56
56
PRs should have passing [GitHub status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) before review is requested (unless there are explicit questions asked in the PR about any failures).
57
57
58
+
#### Asking Questions
59
+
60
+
If you need help and/or have a question, posting a comment in the PR is a great way to do so.
61
+
There's no need to tag anybody individually.
62
+
One of us will drop by and help when we can.
63
+
64
+
Please post comments as [line comments](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-line-comments-to-a-pull-request) when possible, so that they can be threaded.
65
+
You can [resolve conversations](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#resolving-conversations) on your own when you feel they're resolved - no need to comment explicitly and/or wait for a maintainer.
66
+
58
67
#### Requested Changes
59
68
60
69
After a maintainer reviews your PR, they may request changes on it.
@@ -64,6 +73,10 @@ Please try not to force-push commits to PRs that have already been reviewed.
64
73
Doing so makes it harder to review the changes.
65
74
We squash merge all commits so there's no need to try to preserve Git history within a PR branch.
66
75
76
+
Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed.
77
+
78
+
Once all feedback is addressed and the PR is approved, we'll ensure the branch is up to date with `main` and merge it for you.
79
+
67
80
#### Post-Merge Recognition
68
81
69
82
Once your PR is merged, if you haven't yet been added to the [_Contributors_ table in the README.md](../README.md#contributors) for its [type of contribution](https://allcontributors.org/docs/en/emoji-key"Allcontributors emoji key"), you should be soon.
0 commit comments