Fix import and document update functions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbosco
requested changes
Jan 8, 2024
| action: "emplace", | ||
| dirty_values: "coerce_or_drop", | ||
| return_doc: false, | ||
| batch_size: batchSize.length, |
There was a problem hiding this comment.
The batch_size here controls server-side batching, and we do not want to change this from the default in most cases.
Could you remove this?
| exports.importDocumentsConfig = (batchSize) => ({ | ||
| action: "emplace", | ||
| dirty_values: "coerce_or_drop", | ||
| return_doc: false, |
There was a problem hiding this comment.
This is a good improvement, I've seen users miss the error returned because we log the document as well.
But could you instead set return_id: true, so at least the document ID is logged for users to investigate further?
…-on-created-documents-or-documents-without-all-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Stability in Import and Document Update Operations
This pull request addresses and resolves issues in the import and document update functionalities. The changes implemented aim to enhance the stability and reliability of document writes, significantly reducing the occurrence of failures.
Key Changes:
These improvements are expected to offer a more seamless and efficient experience for all users. Your testing and feedback on these changes would be greatly appreciated to ensure we maintain the high standards of the project.