Conversation
Drodt
approved these changes
Aug 30, 2026
Drodt
left a comment
Drodt
left a comment
Collaborator
There was a problem hiding this comment.
It's best to create two PRs for stuff like this in the future, but it's not a big problem.
Thank you!
Collaborator
|
I'm sorry, the GitHub merge editor has failed me. Could you undo my last commit and fix the merge conflict? Same for #119. |
Contributor
Author
Contributor
Author
|
@Drodt it's done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
Additionally, I added Git attributes to avoid some line ending issues (which I've been having a lot).
The tests were basically CRLF (because of my old fixture refactor... sorry), but the added tests are:
test_crossref_...