Repository navigation
Minv 1.0: Linux and Windows installers, review fixes - #1
Merged
Merged
Conversation
Minv-owned package templates replace upstream's, whose postinst added Microsoft's apt repository and signing key. Packages carry Minv's version. Release assets drop the version from their names so releases/latest/download/<asset> always works, with one SHA256SUMS.
File > Preferences, the Manage menu and Ctrl+Shift+X still opened the hidden Extensions view. CI builds linked to Microsoft's source map CDN. Three configuration defaults and three theme colors named keys that don't exist.
Native modules build with upstream's sysroot toolchain so packages run where VS Code does. CI installs the .deb on Ubuntu and the .rpm on Fedora, checks the glibc floor, and checks the tag before the build. The smoke test now fails on capture errors. Capture no longer hangs when the renderer dies and cleans up its profile; prepare refetches when the pin changes.
Minv gets its own win32 AppIds, icon and installer artwork, and patch 0010 replaces Microsoft's publisher, URLs and exe metadata. fork-capture runs without Xvfb on Windows so CI opens the installed app. The release job now needs both platforms and writes one SHA256SUMS. Also fixes the Linux job: build/ dependencies install before the sysroot toolchain needs them.
AppRun starts Electron directly so the AppImage stays mounted, and drops the sandbox only where unprivileged user namespaces are unavailable or blocked by AppArmor. appimagetool is pinned to 1.9.1 and checksum-verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets Minv ready for a full 1.0 release. The release page gets Linux
.deb,.rpmand AppImage packages next to the archive, plus a Windows installer and zip. Review findings are fixed, and the site and README are updated.Release assets
minvto the terminalminv-linux-x64.deb/usr/bin/minv)minv-linux-x64.rpm/usr/bin/minv)minv-linux-x64.AppImage,minv-linux-x64.tar.gzln -s)minv-win32-x64-setup.exe(per-user, no admin)minv-win32-x64.zipAll assets are covered by one
SHA256SUMS. Pushingv<version>builds both platforms, runs every install test, and publishes.Installers
npm run packagenow buildsminv-linux-x64.tar.gz,.deband.rpm, plus oneSHA256SUMS. The asset names don't include a version, soreleases/latest/download/<asset>always points at the newest release, and the site and README never need a version edit.fork/overlay/resources/linux. This matters because upstream's debpostinstsilently added Microsoft's apt repo and signing key, and itspostrmdeleted them, which would break a real VS Code install. The new desktop entry, AppStream data and package descriptions are Minv's.0009-linux-packages: the packages carry Minv's version (1.0.0), not Code-OSS's. It also drops the Microsoft debconf question, and stops failing on the missing tunnel binary or on dependency-list drift (drift is still reported)..debon the Ubuntu runner and launches it, installs the.rpmin a Fedora container, and launches the AppImage. The release body gets an install table.Windows
media/brand/minv.svg.0010-windows: replaces Microsoft's publisher, URLs and exe metadata. It also tolerates a missingsigntool, since Minv's builds are unsigned.windows-2022, because upstream's build only accepts Visual Studio 2019 or 2022. It checks upstream out with LF line endings so the patches apply, installs the setup silently, and opens the app.AppImage
bin/minvCLI would hand off and exit, which unmounts the AppImage.appimagetoolis pinned to 1.9.1 and its checksum is verified.Fixes from the review (three subagents: tooling/CI, in-app leaks, site/docs)
useCdnSourceMapsForPackagingTasks). They no longer do.configurationDefaultsand three theme colors named keys that don't exist. The two SCM graph colors now use the realscmGraph.*ids.package.jsonis1.0.0.teehad nopipefail. All steps now run withshell: bash.fork-capture:xvfb-runtemp dir behind on every run. Both are cleaned up now.fork-prepare: it now fetches again when the pin changes or an earlier fetch was interrupted.gzip -n). Unused config was dropped.latest/download, with buttons for.deb,.rpmand.tar.gz.noindexon the 404 page, and security headers.Tested locally (Fedora 44)
tarandrpm, and installed the.rpmin a cleanfedora:latestcontainer:minv-1.0.0-1,/usr/bin/minv, desktop entry and no repo files..debcan't be built on Fedora (nodpkg-deb). CI builds it and tests the install.1.0.0and requireslibc6 (>= 2.28).mainin the status bar.CI smoke screenshots, taken from the installed packages:
Manage menu, now without Extensions:
Command Palette… · Profiles · Settings · Keyboard Shortcuts · Snippets · Tasks · ThemesSite install section:
After merging, push
v1.0.0to publish the release. The site deploys separately:cd site && wrangler deploy.