chore: bump Go to v1.22 #83
Conversation
Pull Request Test Coverage Report for Build 15427738042Details
💛 - Coveralls |
| @@ -11,27 +11,27 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go-version: ["1.21"] | |||
| go-version: ["1.22"] | |||
There was a problem hiding this comment.
there's no matrix action going on here, this is just an artifact of history. if you're feeling noble you can scrap the whole matrix and inline the version. but also not necessary
There was a problem hiding this comment.
Will probably leave it as is for now haha - is convention to keep this two versions behind latest?
There was a problem hiding this comment.
not a problem! and yes, that's right. it helps make sure that the linter doesn't recommend something in 1.24 that isn't supported in 1.22. Perfect example is the copyloop var change was added in 1.22. but while we supported 1.21, we didn't want to use that rule. using the lowest supported version reinforces that design goal.
| formatters: | ||
| enable: | ||
| - gofmt | ||
| - goimports |
There was a problem hiding this comment.
i didn't vet all these settings, any changes of note besides the comments being correctly enforced and the copyloop linter getting enabled?
There was a problem hiding this comment.
No changes of note - the settings block was copied from the previous linters-settings block (formerly at L1) because the YAML definition had changed with the version bump
Bump go to v1.22 and fix lint issues