feat(submitqueue): cut over internal queues to protojson - #703
Open
behinddwalls wants to merge 1 commit into
Open
feat(submitqueue): cut over internal queues to protojson#703behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary
### Why?
SubmitQueue's pipeline still serialized Go structs with encoding/json, while Stovepipe and the queue-contract RFC use proto3 + protojson with one message per topic key. That left the internal contract without a language-neutral schema and made additive field growth a shared-struct change.
### What?
Add submitqueue/core/messagequeue (proto payloads, protojson glue, TopicKey constants, and entity mapping). Gateway and orchestrator publish and consume the message bound to each topic. MarshalID/UnmarshalID take the topic key so a later field is not discarded onto the wrong type. Proto filenames that collide in the protobuf registry are prefixed (submitqueuemerge, submitqueuebuild, submitqueuebuildsignal). Queue-only ToBytes/FromBytes helpers are removed from entities. Hard cutover: drain or drop in-flight start and log messages; id-only topics stay {id,queue}.
## Test Plan
✅ `bazel test` of `//submitqueue/core/messagequeue:go_default_test` plus gateway and orchestrator/DLQ controller tests
✅ `bazel test //test/e2e/submitqueue:go_default_test --test_filter=TestE2EIntegration`
✅ `bazel test //test/e2e/submitqueue:go_default_test --test_filter=TestGitMergeE2E`
behinddwalls
marked this pull request as ready for review
September 11, 2026 21:56
sbalabanov
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SubmitQueue's pipeline still serialized Go structs with encoding/json, while Stovepipe and the queue-contract RFC use proto3 + protojson with one message per topic key. That left the internal contract without a language-neutral schema and made additive field growth a shared-struct change.
What?
Add submitqueue/core/messagequeue (proto payloads, protojson glue, TopicKey constants, and entity mapping). Gateway and orchestrator publish and consume the message bound to each topic. MarshalID/UnmarshalID take the topic key so a later field is not discarded onto the wrong type. Proto filenames that collide in the protobuf registry are prefixed (submitqueuemerge, submitqueuebuild, submitqueuebuildsignal). Queue-only ToBytes/FromBytes helpers are removed from entities. Hard cutover: drain or drop in-flight start and log messages; id-only topics stay {id,queue}.
Test Plan
✅
bazel testof//submitqueue/core/messagequeue:go_default_testplus gateway and orchestrator/DLQ controller tests✅
bazel test //test/e2e/submitqueue:go_default_test --test_filter=TestE2EIntegration✅
bazel test //test/e2e/submitqueue:go_default_test --test_filter=TestGitMergeE2E