Repository navigation
fix(web): pause the e2e fake clock ahead of its install time - #977
Merged
Merged
Conversation
## Summary ### Why? The header auto-refresh e2e tests install Playwright's fake clock at `now` and then call `pauseAt(now)`. The installed clock keeps running between the two calls, so when even a millisecond passes, `pauseAt` targets the past and throws `Cannot fast-forward to the past`. This failed the Stovepipe suite on #969 while the same test passed locally and on rerun. ### What? - The Stovepipe and SubmitQueue specs pause the clock one minute after the install time, so `pauseAt` always jumps forward. Auto-refresh is still off at that point and the Live indicator depends only on fetch failures, so the jump changes nothing the tests assert. ## Test Plan ✅ `bazel test //web/test/e2e/stovepipe:web_test //web/test/e2e/submitqueue:web_test --sandbox_writable_path=$HOME/.docker --local_test_jobs=1`
behinddwalls
marked this pull request as ready for review
October 28, 2026 21:22
mnoah1
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The header auto-refresh e2e tests install Playwright's fake clock at
nowand then callpauseAt(now). The installed clock keeps running between the two calls, so when even a millisecond passes,pauseAttargets the past and throwsCannot fast-forward to the past. This failed the Stovepipe suite on #969 while the same test passed locally and on rerun.What?
pauseAtalways jumps forward. Auto-refresh is still off at that point and the Live indicator depends only on fetch failures, so the jump changes nothing the tests assert.Test Plan
✅
bazel test //web/test/e2e/stovepipe:web_test //web/test/e2e/submitqueue:web_test --sandbox_writable_path=$HOME/.docker --local_test_jobs=1🤖 Generated with Claude Code