perf(orchestrator): store treehash mapping before graph computation - #266
Merged
Conversation
xytan0056
force-pushed
the
eager-treehash-cache
branch
3 times, most recently
from
August 1, 2026 01:20
36ea8f4 to
65ad7aa
Compare
yushan8
approved these changes
Aug 2, 2026
yushan8
reviewed
Aug 2, 2026
| if putErr := b.storage.Put(b.appCtx, storage.UploadRequest{ | ||
| Key: thCachePath, | ||
| Reader: bytes.NewReader([]byte(treehash)), | ||
| }); putErr != nil { |
Contributor
There was a problem hiding this comment.
shouldn't we return the error if the treehash upload fails? the request will fail if there's no commit -> treehash mapping?
Contributor
There was a problem hiding this comment.
synced offline: Add a metric to track when treehash mapping upload failed
xytan0056
force-pushed
the
eager-treehash-cache
branch
from
August 3, 2026 16:42
65ad7aa to
778476f
Compare
Move the treehash cache write from after the graph computation to before it. This lets concurrent or subsequent requests resolve the BuildDescription→treehash mapping while the current request is still computing the (potentially slow) target graph. The write is now fire-and-forget: failures are logged as warnings but do not fail the request, since the mapping is a performance optimization, not a correctness requirement.
xytan0056
force-pushed
the
eager-treehash-cache
branch
from
August 3, 2026 16:42
778476f to
d083699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildDescription → treehash) from after graph computation to before it, so concurrent/subsequent requests can resolve the mapping while the current request is still computing the target graph.Putis negligible compared to graph compute — the win is in timing, not concurrency.Test plan
bazel test //orchestrator/...passesmake buildpasses