Skip to content

Conversation

ilango123
Copy link

…d Studio Canary and Android-26 SDK

@d4vsanchez d4vsanchez self-assigned this Oct 28, 2017
@d4vsanchez d4vsanchez self-requested a review October 28, 2017 21:06
@d4vsanchez
Copy link

Hello @ilango123, I want to thank you for contributing to this repository.

I have some comments that may be useful before merging this branch onto master:

  1. You're publishing your Fabric API Secrets, which is not recommended for security reasons. It'd be good if you remove them in your branch and regenerate them without publishing them again.

  2. Same that happened in the past point but this time with Google Maps API Key.

I do not recommend you to upload code changes with private keys exposed.

Hope to hear from you soon 😄

Thanks so much for contributing!

@ilangostl
Copy link

Sure. I will remove get rid of the Fabric and Google API stuff.

@ilangostl
Copy link

Hello @Juanda95 I have just committed my changes to my branch. Is there anything else I need to do?

@d4vsanchez
Copy link

Thanks! @ilangostl We're going to start testing the PR.
If it's OK then, we'll be merging this PR onto master in less than 48 hours.

@ilango123
Copy link
Author

I just noticed there are conflicts. How do you propose we handle this? Is it possible for you to do this at your end? Thanks.

@d4vsanchez
Copy link

I've fixed them @ilango123, you don't have to worry about them anymore.

Also, we've been testing this PR with Android Studio 3.0, the stable version is now out there. So we're making some changes and it's currently in QA.

@d4vsanchez d4vsanchez removed their assignment Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants