Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CI can run on forked repo PRs #1104

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Ensure CI can run on forked repo PRs #1104

merged 1 commit into from
Sep 17, 2024

Conversation

didrocks
Copy link
Member

@didrocks didrocks commented Sep 17, 2024

Put the runner here instead of GH project config as it’s not available to the forked repositories otherwise when submitting PRs: https://github.com/orgs/community/discussions/44322.
Workflow environements don’t work either.

Hardcode the runner in the workflow directly instead of GH project
config as it’s not available to the forked repositories otherwise when
submitting PRs: https://github.com/orgs/community/discussions/44322.
Workflow environment variables are not accessible on runs-on either.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (bd1e473) to head (730c7b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          79       79           
  Lines        6917     6917           
=======================================
  Hits         6487     6487           
  Misses        420      420           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks didrocks marked this pull request as ready for review September 17, 2024 07:28
@didrocks didrocks requested a review from a team as a code owner September 17, 2024 07:28
@didrocks didrocks merged commit da48081 into main Sep 17, 2024
4 checks passed
@didrocks didrocks deleted the fix_CI_on_fork branch September 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants