subprojects/dash-to-dock: fix translation installation#12
subprojects/dash-to-dock: fix translation installation#12EriksRemess wants to merge 1 commit intoubuntu:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Dash to Dock translation installation in the Meson-based packaging flow by ensuring gettext outputs are installed and by adjusting the install staging/copy process so locale files aren’t dropped.
Changes:
- Enable installation of gettext translation files by removing
install: falsefromi18n.gettext(...). - Rework the install script to stage the upstream
make installoutput and then copy staged results into the desired package layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| subprojects/packagefiles/dash-to-dock/po/meson.build | Enables gettext translation installation so .mo files are produced and installed. |
| subprojects/packagefiles/dash-to-dock/meson.build | Updates install-time staging/copy logic to preserve upstream install outputs (including locale files). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This fixes Dash to Dock translations not getting installed.
The packaging step already moved the extension files into the layout we want, but the translation files were getting lost along the way. This updates the install flow so we stage the upstream install output first, then copy both the extension files and locale files into the final package layout.