Fix a few warnings#1632
Merged
Merged
Conversation
It's been unused since 1c5627e. Fixes one -Wunused-function warning.
This has been unused since this function was added back in 3a78e80 (called tcd_dc_level_shift_encode back then, in libopenjpeg/tcd.c back then). Fixes a -Wunused-but-set-variable warning.
This has been unused since this function was added back in b551844 (called pi_create_decode_v2 back then, in libopenjpeg/pi.c back then). Fixes a -Wunused-but-set-variable warning.
This has been unused since this function was added back in 3a78e80 (called pi_initialise_encode_v2 back then, in libopenjpeg/pi.c back then). Fixes a -Wunused-but-set-variable warning.
Merged
Contributor
Author
|
This should be harmless to merge, as it's behavior preserving. |
Contributor
Author
|
Hey, the first commit effectively cherry-picks https://source.chromium.org/chromium/chromium/src/+/main:third_party/pdfium/third_party/libopenjpeg/0039-opj_mqc_renorme.patch;l=1?q=0039-opj_mqc_renorme.patch&sq= , so this is in a way part of upstreaming pdfium downstream patches. (I wasn't aware of that when I made this PR.) |
Contributor
Author
|
@rouault Friendliest, gentlest, tendermost ping. |
rouault
approved these changes
May 4, 2026
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, things build without warnings for me (macOX, Xcode 26.2) when using
CMAKE_C_FLAGS="-Wall -Wextra -Wconversion -Wno-unused-parameter -Wdeclaration-after-statement -Werror=declaration-after-statement"
Per #1629 (comment), those are the warnings used on CI.
No intended behavior change.