Repository navigation
struct: advance past whitespace in base64 decoding - #506
Merged
Merged
Conversation
jow-
reviewed
Oct 23, 2026
The whitespace loops in b64dec() never advance src_off, so the decoder can get stuck. Advance it on each iteration, just as the main loop does. Fixes: 6350e63 ("struct: implement X and Z formats for hex and base64 coding") Signed-off-by: darekhta <dmitri.arekhta@me.com>
darekhta
force-pushed
the
fix/struct-base64-whitespace
branch
from
October 23, 2026 13:33
fcdce85 to
60fe600
Compare
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whitespace loops in b64dec() never advance src_off, so the decoder can get stuck. Advance it on each iteration, just as the main loop does.
Fixes: 6350e63 ("struct: implement X and Z formats for hex and base64 coding")