Repository navigation
Conversation
read("all") reads until fread() returns 0 without checking ferror(), so a
failed read ends it like EOF: the data is truncated or empty and fs.error() is
unset.
In uloop hosts such as rpcd, libubox's SIGCHLD handler lacks SA_RESTART, so any
exiting child causes this via EINTR. EINTR is now retried.
Assisted-By: LLM
Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
lvoegl
force-pushed
the
read-all-interrupt
branch
from
October 30, 2026 14:35
8980678 to
d73556c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read("all")stops at the firstfread()that returns 0 without checkingferror(), so a read error looks like an EOF: truncated or empty data, no fs.error().In uloop hosts like rpcd, this is triggered by any exiting child via
EINTR.This PR makes
read("all")retry onEINTR.