docs(v3): documentation including all of the changes made for version 3 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* added new options for floating-ui based menus * added changeset
background-color, font-size, line-height, selection
Richard87
reviewed
Feb 18, 2025
| const pos = nodeViewProps.getPos() | ||
| if (pos !== undefined) { | ||
| // use pos | ||
| } |
There was a problem hiding this comment.
What does it mean the getPos() === undefined, and how should it be handled in that case?
Does it mean the node is not inserted yet / finished rendered?
There was a problem hiding this comment.
ProseMirror/prosemirror-view#153
Once the node has been removed from the document, getPos is no longer valid (since React can hold a reference to getPos after something is deleted)
There was a problem hiding this comment.
ahh, okay, in my specific case, I have an action addChild, so if getPos() returns undefined, I should not do anything probably :)
thanks for the quick reply!
…details extension (#103)
* update docs for undo-redo extension * add changesets
* update docs for collaboration cursor to reflect name changes * add changesets
|
The preview is private. Is that intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to show the documentation for version 3 of tiptap