Skip to content

Added modal auto-closing on Settings Submit#46

Open
gderiyenko wants to merge 4 commits intoujain1999:mainfrom
gderiyenko:auto_close
Open

Added modal auto-closing on Settings Submit#46
gderiyenko wants to merge 4 commits intoujain1999:mainfrom
gderiyenko:auto_close

Conversation

@gderiyenko
Copy link
Copy Markdown
Contributor

This PR fixes the issue #45

@gderiyenko
Copy link
Copy Markdown
Contributor Author

Created new component ./widgets/notification.js, since it is used in index.html and in options.html.

In order to pass notification message through a page reload, I used localStorage [pendingNotification].

On page initialization: 1. check for pending notification, 2. flush the message

@ujain1999
Copy link
Copy Markdown
Owner

I agree with this change but I think the code for notifications should not live in the widgets folder. In the current scope of the project, widgets are the modules that appear in the sidebar. Move the code for notifications to main.js

@BaldrianSector
Copy link
Copy Markdown
Collaborator

BaldrianSector commented Dec 18, 2025

Should this wait till after the #52 refactor @ujain1999 to avoid merge conflicts?

@BaldrianSector BaldrianSector linked an issue Dec 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-close modal on "Save changes" & "Restore defaults"

3 participants