Added modal auto-closing on Settings Submit#46
Open
gderiyenko wants to merge 4 commits intoujain1999:mainfrom
Open
Added modal auto-closing on Settings Submit#46gderiyenko wants to merge 4 commits intoujain1999:mainfrom
gderiyenko wants to merge 4 commits intoujain1999:mainfrom
Conversation
Contributor
Author
|
Created new component In order to pass notification message through a page reload, I used
|
Owner
|
I agree with this change but I think the code for notifications should not live in the widgets folder. In the current scope of the project, widgets are the modules that appear in the sidebar. Move the code for notifications to main.js |
Collaborator
|
Should this wait till after the #52 refactor @ujain1999 to avoid merge conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #45