fix: resolve auto-hide visibility and settings loading issues (#60)#61
Open
eeviriyi wants to merge 1 commit intoujain1999:mainfrom
Open
fix: resolve auto-hide visibility and settings loading issues (#60)#61eeviriyi wants to merge 1 commit intoujain1999:mainfrom
eeviriyi wants to merge 1 commit intoujain1999:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the auto-hide buttons feature that was not working properly due to JavaScript inline style overrides and incomplete settings merging. The fix ensures that control buttons (customize, theme toggle, photo credit, and refresh background) are properly hidden/shown when the "Auto-hide control buttons" option is enabled.
Changes:
- Merged stored settings with default settings to ensure new settings fields are always present
- Replaced inline
opacity: 1with empty string to allow CSS rules to take precedence - Extended auto-hide CSS rules to include photo-credit and refresh-background buttons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| style.css | Added .photo-credit and .refresh-background to auto-hide CSS selectors for consistent control button behavior |
| main.js | Fixed settings merge logic and removed inline opacity overrides that prevented CSS auto-hide rules from working |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description This PR fixes the auto-hide buttons issue by removing inline opacity overrides and ensuring settings merge correctly. Key Changes:
Fixes #60