Repository navigation
Share one MongoDB container across the datastore tests - #96
Merged
Merged
Conversation
Datastore tests repeatedly started MongoDB containers, taking 20-30s on a healthy runner and exceeding the 60s test timeout on a slow one. Start one container in TestMain and use separate databases to isolate test data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
datastoretests repeatedly started MongoDB containers. The package took 20-30s on a healthy runner, and thebuildjob on master (Bump golang.org/x/net) failed when a slow runner pushed it past the 60sgo testtimeout.After this change,
TestMainstarts one container for the package, and tests that access stored data use separate databases for isolation. The package now runs in about 3s locally. No production code changes.Verified with
go test -timeout=60s -race ./...andgolangci-lint run.