Skip to content

Allow null device redirection in path scope#3245

Open
hiSandog wants to merge 1 commit into
ultraworkers:mainfrom
hiisandog:fix/small-cleanup-a832ee
Open

Allow null device redirection in path scope#3245
hiSandog wants to merge 1 commit into
ultraworkers:mainfrom
hiisandog:fix/small-cleanup-a832ee

Conversation

@hiSandog

Copy link
Copy Markdown
Contributor

Summary

  • allow WorkspacePathScope to treat /dev/null as a null-device sink instead of an out-of-workspace path
  • add coverage for echo ok >/dev/null

Validation

  • python3 -m unittest tests.test_security_scope
  • python3 -m unittest discover tests

@1716775457damn

Copy link
Copy Markdown

LGTM on the approach. Treating /dev/null as a null-device sink in path scope makes sense since it's a side-effect-free operation. One suggestion: consider documenting this behavior clearly in the security scope docs so users understand why /dev/null is exempt from path restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants