V15 Added second level block acceptance tests #19264
Open
+496
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…level-block-tests
…level-block-tests # Conflicts: # tests/Umbraco.Tests.AcceptanceTest/package-lock.json # tests/Umbraco.Tests.AcceptanceTest/package.json
There was a problem hiding this comment.
Pull Request Overview
This PR adds a suite of acceptance tests to validate the functionality of second-level block properties in various editors including rich text editors, block list editors, and block grid editors. Key changes include tests for nested rich text editors, block grid editors, and block list editors to ensure proper content creation, publication, and notification flow.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/SecondLevelBlockProperties.spec.ts | New tests validating nested rich text editor block behavior. |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/SecondLevelBlockProperties.spec.ts | New tests validating nested block list editors with combinations of nested grids and lists. |
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/SecondLevelBlockProperties.spec.ts | New tests validating nested block grid editors with combinations of nested grids and lists. |
Files not reviewed (2)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
- tests/Umbraco.Tests.AcceptanceTest/package.json: Language not supported
...ests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/SecondLevelBlockProperties.spec.ts
Outdated
Show resolved
Hide resolved
...ests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/SecondLevelBlockProperties.spec.ts
Show resolved
Hide resolved
nhudinh0309
requested changes
May 8, 2025
| const secondBlockListDataTypeName = 'SecondBlockListName'; | ||
| const blockListElementTypeName = 'BlockListElementName'; | ||
| const blockListElementGroupName = 'ListElementGroup'; | ||
| await umbracoApi.dataType.ensureNameNotExists(blockListDataTypeName); |
There was a problem hiding this comment.
Remove it as it is included in the beforeEach()
| expect(documentValues.value.contentData[0].values[0].value.contentData[0].values[0].value).toContain(textStringValue); | ||
|
|
||
| // Clean | ||
| await umbracoApi.dataType.ensureNameNotExists(blockListDataTypeName); |
There was a problem hiding this comment.
Remove it as it is included in the afterEach()
| expect(secondRTEInBlock.value.markup).toContain(secondExpectedRichTextEditorOutputValue); | ||
|
|
||
| // Clean | ||
| await umbracoApi.dataType.ensureNameNotExists(richTextDataTypeName); |
There was a problem hiding this comment.
Remove it as it is included in the afterEach()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.