Skip to content

Simplify descriptions, labels and notification messages for publishing #19267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 9, 2025

Conversation

madsrasmussen
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 14:15
@madsrasmussen madsrasmussen requested a review from nielslyngsoe May 7, 2025 14:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the descriptions and labels used in the publishing-related modals and translations to streamline the user interface messaging. The changes include updating modal headlines, revising confirmation texts, and refining language strings in the locale files.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts Added a headline property with an updated translation key for the save and publish modal
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts Revised the unpublish modal confirmation text and simplified the layout
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/modal/document-schedule-modal.element.ts Removed conditionally rendered subtitle to simplify the UI
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish/modal/document-publish-modal.token.ts Introduced an optional headline property for the publish modal data
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish/modal/document-publish-modal.element.ts Updated the publish modal to use a provided headline or fallback translation key, along with a simplified confirmation message
src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.element.ts Eliminated an extra subtitle and updated the primary save button label
src/Umbraco.Web.UI.Client/src/assets/lang/en.ts and en-us.ts Revised labels and confirmation message texts to reflect the simplified descriptions
Comments suppressed due to low confidence (5)

src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts:311

  • Ensure that the translation key 'content_saveAndPublishModalTitle' is defined in all locale files to maintain consistent modal headlines across the application.
headline: this.#localize.term('content_saveAndPublishModalTitle'),

src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish/modal/document-publish-modal.element.ts:104

  • Verify that the fallback translation key 'content_publishModalTitle' exists in the locale files, ensuring that the publish modal always displays a proper headline.
const headline = this.data?.headline ?? this.localize.term('content_publishModalTitle');

src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.element.ts:68

  • [nitpick] Changing the button label from 'buttons_saveAndClose' to 'buttons_save' aligns with the simplified copy; confirm that this change is consistent with the overall UI behavior.
label="${this.localize.term('buttons_save')}"

src/Umbraco.Web.UI.Client/src/assets/lang/en.ts:162

  • [nitpick] Review this updated label to ensure that 'Schedule publish' is consistent with the new UI terminology and meets the design guidelines.
schedulePublish: 'Schedule publish',

src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts:137

  • [nitpick] Confirm that the updated locale label 'Schedule publish' in en-us aligns with the revised UI language and is consistent with the other locale files.
schedulePublish: 'Schedule publish',

@madsrasmussen madsrasmussen changed the title Simplify descriptions and labels around publishing Simplify descriptions, labels and notification messages for publishing May 7, 2025
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) May 9, 2025 08:22
@nielslyngsoe nielslyngsoe merged commit a8f58d8 into release/16.0 May 9, 2025
23 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/hotfix/simplify-publishing-modal-texts branch May 9, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants