Improve active state check for menu and tree item #19281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
added
release/16.0.0
release/16.0.0-rc2
type/bug
category/ux
There was a problem hiding this comment.
Pull Request Overview
This PR refines the active state check for menu and tree items by ensuring path comparisons include a trailing slash to avoid false positives when one path is a substring of another.
- Updated the active state logic in tree items by applying ensureSlash to both the current location and the item's path.
- Updated the active state logic in menu items by applying ensureSlash to both the current location and the item's href.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts | Applies ensureSlash to the location and tree item path to prevent incorrect active state highlighting. |
| src/Umbraco.Web.UI.Client/src/packages/core/menu/components/menu-item-layout/menu-item-layout.element.ts | Applies ensureSlash to the location and menu href to prevent collisions in active state detection. |
...raco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts
Show resolved
Hide resolved
...Web.UI.Client/src/packages/core/menu/components/menu-item-layout/menu-item-layout.element.ts
Show resolved
Hide resolved
nielslyngsoe
approved these changes
May 9, 2025
…-tree-item # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the active state check for menu and tree items to prevent highlighting multiple items when paths include the same part.
Before
Currently, these items are both shown as active:
/test-1/test-1-2Because
/test-1is part of both of them.After
With the new solution, we add a slash at the end of the part we compare, so the check now looks like this:
/test-1//test-1-2//test-1/is not part of/test-1-2/.