Skip to content

Conversation

@andr317c
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 23, 2025 10:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cherry-picks QA acceptance test fixes and improvements from version 17 into the current branch. The changes primarily focus on updating test assertions to match corrected error messages, removing test tags, renaming methods for consistency, and updating dependencies.

Key Changes:

  • Updated error message assertions to reflect corrected grammar in validation messages
  • Removed @release tags from webhook-related tests
  • Renamed test helper methods for better semantic clarity

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WebhookTrigger.spec.ts Removed @release tag from content publish trigger test
Webhook.spec.ts Removed @release tag from webhook event validation test
Media.spec.ts Added navigation step to media section before assertions
BlockListEditor.spec.ts Updated error message assertion to match corrected grammar and punctuation
BlockGridEditor.spec.ts Updated error message assertion to match corrected grammar and punctuation
CreateContentFromDocumentBlueprint.spec.ts Renamed method calls from clickModalMenuItemWithName to selectDocumentBlueprintWithName
ContentWithTrueFalse.spec.ts Changed assertion from empty array to explicit false boolean value
ContentWithAllowedChildNodes.spec.ts Renamed method call from doesModalHaveText to doesDocumentModalHaveText
ContentInfoTab.spec.ts Updated status text from 'This item is not published' to 'Not created'
Content.spec.ts Replaced tree navigation methods with list-based content verification
package.json Updated playwright-testhelpers dependency from 16.0.55 to 16.0.56
Files not reviewed (1)
  • tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant