Skip to content

Conversation

filipopo
Copy link
Contributor

"Fixes" #337

Copy link
Owner

@umihico umihico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I have several suggestions to improve the documentation:

  1. Missing rebuild instructions

The current example shows changing the code and then running the container, but it's missing the rebuild step:

  • To get more than a minimal example, change the code and then run the container
  • To get more than a minimal example, change the code, rebuild the image, and then run the container

You should add the rebuild command before running:
docker build -t my-selenium-lambda .
docker run --name selenium-lambda-demo -p 9000:8080 my-selenium-lambda

  1. Add language specifiers to code blocks

All code blocks should have language specifiers for proper syntax highlighting:

  • Shell commands: ```bash
  • Python code: ```python
  1. Use permalink for code reference

Instead of:
Change https://github.com/umihico/docker-selenium-lambda/blob/main/main.py#L25

Use a permalink to a specific commit to prevent broken links when the file changes:
Change https://github.com/umihico/docker-selenium-lambda/blob/7a19acc/main.py#L25

  1. Container naming

The container name "demo" is too generic. Consider using something more specific like:

  • selenium-lambda-demo
  • aws-lambda-selenium-demo
  1. Serverless framework example verification

Has the serverless framework example been tested?
sls invoke --function demo --data '{"url": "https://github.com"}'
Please confirm this works with the current setup.

@filipopo
Copy link
Contributor Author

filipopo commented Aug 10, 2025

Done but regarding 5. I must admit, I never used sls in my life😅I tested everything else though. Maybe you can test it or I'll try doing it later

@umihico
Copy link
Owner

umihico commented Aug 11, 2025

Then please just remove the step. Unconfirmed commands should never be on the README..

BTW, did you confirm others?

@filipopo
Copy link
Contributor Author

I had a small typo because my intention in #337 was to put "target" in the event, otherwise everything works 💪
image

@filipopo
Copy link
Contributor Author

Is there anything else that you'd like to change @umihico ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants