Repository navigation
Say what the yt-dlp updater will actually do at startup - #180
Merged
Merged
Conversation
The startup line keyed off the interval alone, so a config with an interval and no command logged 'updater enabled' and then never ran anything, and one with only force_on_startup logged 'periodic updater is disabled', which reads as the whole feature being off. Neither told the operator whether the ytdlp_update section had been read at all, and config parsing is a plain yaml.Unmarshal, so a misplaced key is silently ignored. The line now states the resulting behaviour: disabled with no command, on startup only, every interval, both, or never when a command is set with neither trigger. README claimed an omitted interval means yt-dlp will not be updated, which is false when force_on_startup is set. Related to #169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the yt-dlp updater's startup line keyed off the interval alone, so it could not be trusted as a signal that the
ytdlp_updatesection had been read.two cases were actively misleading. An interval with no command logged
yt-dlp updater enabled, interval 24hand then never executed anything, because the tick path is guarded on the command being non-empty.force_on_startup: truewith no interval loggedyt-dlp periodic updater is disabled, which reads as the whole feature being off even though the startup run does happen.the line now states the resulting behaviour: disabled when no command is set, on startup only, every interval, both, or never when a command is set with neither trigger.
it also moved inside the goroutine, after the
disable_updatesearly return. Where it was, a config with a command anddisable_updates: trueannounced work thatDowas never reached to perform, which is the same untruthful status this change is about.README.mdsaid an omitted interval means yt-dlp will not be updated. That is false whenforce_on_startupis set.context is #169, where the reporter sees no evidence the command is invoked. This does not diagnose that report and it stays open; the startup line was simply not good enough to tell the two situations apart.
Related to #169