Repository navigation
docs: correct what the youtube item limits actually control - #181
Merged
Merged
Conversation
max_per_channel was documented as the per-channel download limit, which it is not. setDefaults gives every channel Keep from system.max_per_feed when the channel sets none, and for a configured channel with a positive effective keep that value overrides max_per_channel for downloads. What max_per_channel does limit is the channel source page, RSS requests for channel ids absent from the config, and files written by POST /yt/rss/generate. Also documents that the upstream feed returns only a window of recent entries, so a limit above that window raises retention rather than fetching more per poll, and adds a backlog item for the generate/serve limit split this turned up. Fixed #125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrects the youtube limit documentation after #125.
max_per_channelwas documented as the per-channel download limit, which it is not: a channel with no explicitkeepgets itsKeepfromsystem.max_per_feed, and for a configured channel with a positive effectivekeepthat value overridesmax_per_channelfor downloads.the note under the config example says what the effective
keepcontrols, including that cleanup retains up tokeep + 1, and that the upstream feed returns only a window of recent entries so a limit above it raises retention rather than fetching more per poll.also adds a backlog item for the generate/serve limit split this turned up:
POST /yt/rss/generatedrops the channel'sKeepand so usesmax_per_channel, whileGET /yt/rss/{channel}for configured channels and the automatic writes usekeep.Fixed #125