Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove layout definition #1

Closed
wants to merge 1 commit into from

Conversation

unailopez16
Copy link
Owner

fixes magento#537

Description (*)

This PR removes the layout definition from Magento\PageBuilder module in category view pages, since it's already defined in Magento\Catalog module, and due to layouts loading order it breaks the ability to apply a custom layout type from a category edit page in backou

Bug

Fixed Issues (if relevant)

  1. Layout shouldn't be set in a page_layout xml file. magento/magento2-page-builder#537: Layout shouldn't be set in a page_layout xml file.

Manual testing scenarios (*)

  1. Install Magento\PageBuilder y a M2.4.3 fresh instance
  2. Go to Catalog -> Categories
  3. Edit one category
  4. Apply a custom layout type in Design Section
  5. Layout type is not applied to front page category

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

engcom-Hotel pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout shouldn't be set in a page_layout xml file.
1 participant