Skip to content

chore: sync release workflow with replicator template - #231

Merged
jflowers merged 1 commit into
unbound-force:mainfrom
yvonnedevlinrh:chore/sync-release-workflow
Aug 20, 2026
Merged

chore: sync release workflow with replicator template#231
jflowers merged 1 commit into
unbound-force:mainfrom
yvonnedevlinrh:chore/sync-release-workflow

Conversation

@yvonnedevlinrh

Copy link
Copy Markdown
Contributor

Summary

Syncs safe improvements from the replicator release workflow template
(unbound-force/replicator#61) and dewey's recent sync (unbound-force/dewey#104).

Changes

  1. Add allow_prerelease: true to preflight inputs — enables prerelease
    tags (e.g., v1.7.0-rc.1) to pass the org-infra semver ordering check.
    Without this, the preflight reusable workflow rejects prerelease tags.

  2. Add cleanup signing materials step to sign-macos job — removes the
    P12 certificate, notary key, and temporary keychain from the runner even
    if earlier steps fail (if: always()). Defense-in-depth for secret
    material hygiene on macOS runners.

Not included

  • Concurrency deadlock fix (dewey#105): Gaze's release.yml has no
    top-level concurrency: block, so this issue doesn't apply.
  • check-secrets output key renaming: Gaze already uses consistent
    naming (has_signing_secrets / has_secrets).

@em-redhat em-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Two clean, additive changes synced from the replicator release workflow template:

  1. allow_prerelease: true — Enables prerelease tags (e.g., v1.7.0-rc.1) via the reusable preflight workflow input. Follows the same pattern as the existing skip_* inputs.

  2. Cleanup signing materials step — Removes P12 cert, notary key, and temporary keychain with if: always() on the sign-macos job. Paths match creation sites exactly (cert.p12 at line 142, notary_key.p8 at line 156, app-signing.keychain-db at line 139). Defense-in-depth security hardening for credential material on macOS runners.

No findings. Convention pack compliant. No gatekeeping values modified.

- Add allow_prerelease: true to preflight inputs
- Add cleanup signing materials step (if: always()) to sign-macos job

Syncs safe improvements from unbound-force/replicator#61 and
unbound-force/dewey#104.
@jflowers
jflowers force-pushed the chore/sync-release-workflow branch from d74c843 to 5c9ae6e Compare August 20, 2026 16:53
@jflowers
jflowers merged commit 1e67613 into unbound-force:main Aug 20, 2026
5 checks passed
@yvonnedevlinrh
yvonnedevlinrh deleted the chore/sync-release-workflow branch August 21, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for Review 👀

Development

Successfully merging this pull request may close these issues.

4 participants