Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative for releaseable? that doesn't always evaluate to true. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EvenMoreIrrelevance
Copy link

Due to how satisfies? works and due to Object and nil implementations being defined for Release, release? effectively is a clone of any? under any sensible circumstances.

Simply altering releaseable? is a breaking change, so this pull request introduces a nontrivially-releaseable? fn which checks if the object isn't nil and if its implementation is different from Object's and a note about it in release?'s docs.

@blueberry
Copy link
Member

blueberry commented Jan 29, 2025

I won't be able to look at this in the next couple of weeks, but will look at it and consider it after that. Thanks for being patient.

Can you please see how it's used in other uncomplicate code? Maybe releasable can be re-defined to match your intentions with nontrivially-releaseable?

@EvenMoreIrrelevance
Copy link
Author

EvenMoreIrrelevance commented Jan 29, 2025

Searching for releaseable?, releaseable_QMARK_ or looking for usages of (satisfies? Releaseable ...) didn't yield any usage results in all uncomplicate repos (somewhat expected honestly).

@blueberry
Copy link
Member

Then I guess it's a vestige of some long-gone code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants